Add cursorRedo command (Ctrl+Shift+J)#82620
Merged
alexdima merged 2 commits intomicrosoft:masterfrom Oct 18, 2019
Merged
Conversation
3505c10 to
e9fee2c
Compare
e9fee2c to
a1ff866
Compare
Contributor
Author
|
@alexandrudima you completely deleted my entire code without even leaving a comment. What gives? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a command called
cursorUndowhich is used to undo cursor and selection changes.The undo stack is flushed when the text changes.
This PR adds a
cursorRedocommand to complementcursorUndo, and binds it to Ctrl+Shift+J by default.This fixes #82007
How to test
Implementation
To do this I refactored the code to separate the part that interacts with the editor (
CursorUndoController) from the cursor undo/redo logic (CursorStateStack).Previously a list of cursor states was kept, and to undo the state it would pop the latest state from the list.
This PR changes that to a list of cursor states and an index to where we are currently inside that list.
When undoing or redoing the index is moved without deleting any states from the list.
When the state changes, all the states after where we are currently inside the list are dropped, and the new state is added.