Skip to content

add support for command line arguments in grunt task runner#82819

Merged
alexr00 merged 1 commit intomicrosoft:masterfrom
sohailrajdev97:grunt-args
Oct 18, 2019
Merged

add support for command line arguments in grunt task runner#82819
alexr00 merged 1 commit intomicrosoft:masterfrom
sohailrajdev97:grunt-args

Conversation

@sohailrajdev97
Copy link
Member

This PR fixes #66748

This PR adds the support to pass task arguments from grunt task runner extension. I have created a sample repository (as suggested by @alexr00) for checking the functionality here. Steps to check the functionality:

  1. Clone the repository
  2. Install the dependencies using npm install
  3. Build vscode with this added functionality
  4. Test the task which has been defined in tasks.json of the sample repository. This task passes a command line argument to the task runner

@alexr00 alexr00 self-assigned this Oct 18, 2019
@alexr00 alexr00 self-requested a review October 18, 2019 08:17
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! Looks like you also fixed a bug. Thanks for the sample repository, it made it quick and easy to test this.

@alexr00 alexr00 merged commit e10218c into microsoft:master Oct 18, 2019
@alexr00 alexr00 added this to the October 2019 milestone Oct 18, 2019
@sohailrajdev97 sohailrajdev97 deleted the grunt-args branch October 18, 2019 09:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support grunt task argument

2 participants