Add a clear button to settings editor search bar#82904
Merged
roblourens merged 1 commit intomicrosoft:masterfrom Oct 23, 2019
Merged
Add a clear button to settings editor search bar#82904roblourens merged 1 commit intomicrosoft:masterfrom
roblourens merged 1 commit intomicrosoft:masterfrom
Conversation
|
|
smilegodly
force-pushed
the
clearButtonForSettingsEditor
branch
2 times, most recently
from
38383fd to
27cebbc
Compare
smilegodly
force-pushed
the
clearButtonForSettingsEditor
branch
from
27cebbc to
1fc990a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a clear button to the settings editor search bar...
This clear button works the same as the one in the keyboard shortcuts editor, it clears the input that is in the search bar and then refocuses.
This is helpful if you want to clear the search bar while browsing results as the clear search option that is currently implemented doesn't pop up on search results. The button saves the extra step of having to backspace and retype your search as its just 1 click that does this.
This PR fixes #66141