Fixes terminal env variables don't resolve in empty workspaces#83369
Merged
Tyriar merged 5 commits intomicrosoft:masterfrom Dec 31, 2019
Merged
Fixes terminal env variables don't resolve in empty workspaces#83369Tyriar merged 5 commits intomicrosoft:masterfrom
Tyriar merged 5 commits intomicrosoft:masterfrom
Conversation
Tyriar
approved these changes
Dec 31, 2019
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Thanks it works great, plus after the null/undefined clean up it looks a lot better.
Sorry about taking so long, things pile up 😅
|
Thank you @jeanp413 for this - I was running into issues with this and hadn't figured out what was causing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #70323