Fix zoom on first click#83826
Merged
mjbvz merged 3 commits intomicrosoft:masterfrom Nov 5, 2019
MartinBrathen:master
Merged
Conversation
…oom-out on first click when ctrl/alt is pressed
Contributor
Author
|
@mjbvz I've found a bug where the
When trying this on stable 1.39.2 the same visual bug appears, where image A does not seem to get focus. This bug effects this PR and #82074 since both rely on |
Collaborator
|
Thanks. The fix looks good! Can you open a new issue for the webview problem so I can investigate |
Contributor
Author
|
Thanks! I'll have it done by tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #81877
The problem was that fast clicks would zoom on first click. I fixed this by adding the state variable
isActivethat keeps track of when the preview is active or not.I also changed the name of a function from
changeActive(value)tosetActive(value)to make the code more intuitive.I moved a
postMessagecall out of theupdate()function to avoid unnecessary calls.Please let me know if any of these last two changes are unwanted and I'll revert them.