Fix minor packaging issues in automation lib#83942
Merged
Tyriar merged 5 commits intomicrosoft:masterfrom Nov 7, 2019
Merged
Conversation
Member
Author
Tyriar
requested changes
Nov 5, 2019
Member
|
Hmm, using && didn't used to work on Windows but it seems fine now in both Pipelines and Actions, guess that's fine. |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some minor issues that affected building and consumption of the automation library externally via an npm package:
postinstallnpm script. This should not be run after installing the automation package because the npm package includes only the already-compiled output. And that script is not necessary for vscode smoketests because thesmokepackage runsyarn --cwd ../automation compileduring its compilation.drivermodule export inindex.ts..npmignore.gitignoreNone of these changes should have any impact on building or running the vscode smoke tests. Anyway, I verified that the vscode smoke tests are still passing.