Skip to content

Fix minor packaging issues in automation lib#83942

Merged
Tyriar merged 5 commits intomicrosoft:masterfrom
jasongin:automation-fixes
Nov 7, 2019
Merged

Fix minor packaging issues in automation lib#83942
Tyriar merged 5 commits intomicrosoft:masterfrom
jasongin:automation-fixes

Conversation

@jasongin
Copy link
Member

@jasongin jasongin commented Nov 4, 2019

This PR fixes some minor issues that affected building and consumption of the automation library externally via an npm package:

  • Remove the postinstall npm script. This should not be run after installing the automation package because the npm package includes only the already-compiled output. And that script is not necessary for vscode smoketests because the smoke package runs yarn --cwd ../automation compile during its compilation.
  • Fix the driver module export in index.ts.
  • Add .npmignore
  • Update .gitignore

None of these changes should have any impact on building or running the vscode smoke tests. Anyway, I verified that the vscode smoke tests are still passing.

@jasongin
Copy link
Member Author

jasongin commented Nov 4, 2019

@Tyriar

@Tyriar Tyriar self-assigned this Nov 4, 2019
@Tyriar Tyriar added this to the October 2019 milestone Nov 4, 2019
@alexdima alexdima modified the milestones: October 2019, November 2019 Nov 6, 2019
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine here 👍

@Tyriar
Copy link
Member

Tyriar commented Nov 7, 2019

Hmm, using && didn't used to work on Windows but it seems fine now in both Pipelines and Actions, guess that's fine.

@Tyriar Tyriar merged commit b73d1b4 into microsoft:master Nov 7, 2019
@jasongin
Copy link
Member Author

jasongin commented Nov 7, 2019

Thanks!

@jasongin jasongin deleted the automation-fixes branch November 7, 2019 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants