Skip to content

Add builder-method for snippet choice#84048

Merged
jrieken merged 4 commits intomicrosoft:masterfrom
okmttdhr:snippet-choice-builder-method
Nov 13, 2019
Merged

Add builder-method for snippet choice#84048
jrieken merged 4 commits intomicrosoft:masterfrom
okmttdhr:snippet-choice-builder-method

Conversation

@okmttdhr
Copy link
Contributor

@okmttdhr okmttdhr commented Nov 6, 2019

This PR fixes #43643

@msftclas
Copy link

msftclas commented Nov 6, 2019

CLA assistant check
All CLA requirements met.

@okmttdhr okmttdhr force-pushed the snippet-choice-builder-method branch from fce5cc0 to 92b36ff Compare November 9, 2019 12:15
@okmttdhr okmttdhr requested a review from jrieken November 9, 2019 12:17
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks so far. one last thing that's left is to add the signature to the type in vscode.d.ts

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - one last thing: To expose this to extension authors, copy the new signature to the type declaration in vscode.d.ts, e.g here

appendVariable(name: string, defaultValue: string | ((snippet: SnippetString) => any)): SnippetString;

@jrieken jrieken added this to the November 2019 milestone Nov 9, 2019
@okmttdhr okmttdhr requested a review from jrieken November 10, 2019 01:20
@jrieken jrieken merged commit 0a0f2bf into microsoft:master Nov 13, 2019
@okmttdhr okmttdhr deleted the snippet-choice-builder-method branch November 14, 2019 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SnippetString doesn't have builder-method for Choice

3 participants