Add builder-method for snippet choice#84048
Merged
jrieken merged 4 commits intomicrosoft:masterfrom Nov 13, 2019
Merged
Conversation
jrieken
requested changes
Nov 7, 2019
fce5cc0 to
92b36ff
Compare
jrieken
reviewed
Nov 9, 2019
Member
jrieken
left a comment
There was a problem hiding this comment.
lgtm. thanks so far. one last thing that's left is to add the signature to the type in vscode.d.ts
jrieken
reviewed
Nov 9, 2019
jrieken
approved these changes
Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #43643