Adopt insert & replace in snippet provider#84206
Merged
jrieken merged 2 commits intomicrosoft:masterfrom Nov 18, 2019
Merged
Conversation
jrieken
requested changes
Nov 8, 2019
jeanp413
force-pushed
the
adopt-insert-replace-snippets
branch
from
1e4059f to
8e91d73
Compare
Contributor
Author
|
Updated the PR and added some unit tests. Let me know if more changes are needed |
jrieken
approved these changes
Nov 15, 2019
Member
jrieken
left a comment
jrieken
left a comment
There was a problem hiding this comment.
Looking good. Optionally, use the endsWith-util instead of the commonPrefixLength trick, otherwise I'll merge on Monday
Contributor
Author
|
Do you mean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83834