#82105 Add Terminal Rename Command#84429
Merged
Tyriar merged 7 commits intomicrosoft:masterfrom Nov 25, 2019
petevdp:petevdp/add-terminal-rename-command
Merged
#82105 Add Terminal Rename Command#84429Tyriar merged 7 commits intomicrosoft:masterfrom petevdp:petevdp/add-terminal-rename-command
Tyriar merged 7 commits intomicrosoft:masterfrom
petevdp:petevdp/add-terminal-rename-command
Conversation
Tyriar
requested changes
Nov 25, 2019
Member
Tyriar
left a comment
There was a problem hiding this comment.
Doh, forgot to post this review earlier
| export class RenameActiveTerminalCommand extends Command { | ||
| public static readonly ID = TERMINAL_COMMAND_ID.RENAME_NONINTERACTIVE; | ||
| public static readonly LABEL = nls.localize( | ||
| 'workbench.action.terminal.renameNoninteractive', |
Member
There was a problem hiding this comment.
I think renameWithArgs is the better name, interactive/non-interactive has a very specific meaning when talking about shells so this avoids clashing with that terminology.
Contributor
Author
|
Thanks @Tyriar! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #82105 by registering a new command
workbench.action.terminal.renameNoninteractivethat allows the user to set the terminal title via an argument instead of interactively.example usage:
{ "key": "ctrl+t", "command": "workbench.action.terminal.renameWithArgs", "args": { "newName": "my new terminal name" } }The current changes acheive this, but a few things still have to be sorted out:
index, and not changing the default behaviour.How should I notify the user if the desired terminal doesn't exist? I'm guessing you can just throw an error, but if there's a preferred channel or preferred error message formatting, that would be good to adhere to.edit: 231d559 deals with this, but the error formatting still might not be ideal.Any additional suggestions for preferred/extended functionality are welcome!