#83646 Webview: Cannot load resource outside of protocol root", if .md source is an network share#84702
#83646 Webview: Cannot load resource outside of protocol root", if .md source is an network share#84702mjbvz merged 3 commits intomicrosoft:masterfrom hadzhiyski:vh/open-md-from-shared-folder
Conversation
ElectronWebviewBasedWebview local resource roots are with uppercase authority (host name)
hadzhiyski
changed the title
|
Hello, @mjbvz , I am quite new to the vscode repository. Could you give me any guidelines if I am missing something? In my opinion the issue is fixed with latest changes. |
|
|
||
| // windows paths are case insensitive | ||
| // when checking remote host, the host name is uppercase | ||
| if (extensionLocation && ( |
There was a problem hiding this comment.
Are you sure this is the correct fix? This code only applies if the extension is running remotely (which seems unrelated to #83646)
There was a problem hiding this comment.
Yeah... I was mistaken. I think I fixed it with the latest changes. The issue comes from the following - Electron is providing the UNC root authority in uppercase and the resource is requested with lowercase authority.
There was a problem hiding this comment.
isUNC(root.fsPath) && isUNC(resource.fsPath) this should do. It's tested on a Windows 10 desktop.
|
Thanks! This fix will be in the next insiders build and is scheduled to ship with VS Code 1.41 early next month |
|
Thank you for the support! |
2 participants
ElectronWebviewBasedWebview local resource roots are with uppercase authority (host name)
This PR fixes #83646