#84696 Modify git add/revert to use splitInChunks#84843
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom May 27, 2020
jzyrobert:jzyrobert/fix-84696
Merged
#84696 Modify git add/revert to use splitInChunks#84843joaomoreno merged 1 commit intomicrosoft:masterfrom jzyrobert:jzyrobert/fix-84696
joaomoreno merged 1 commit intomicrosoft:masterfrom
jzyrobert:jzyrobert/fix-84696
Conversation
|
@joaomoreno Do you mind rerunning checks on this? I wanted to give a hand on this issue and fix tests, but it seems that all of the failing ones are flaky. |
Contributor
Author
|
Should I rebase this onto master again? |
Member
|
@jzyrobert No, it's OK. |
|
Can we get this PR resolved? I am using insiders and keep butting up against this issue as I do a lot of architectural refactoring on a big project in vscode. |
Contributor
Author
|
@joaomoreno I've rebased it on top of recent updates, do you have any opinions on this? |
Member
|
Thanks! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #84696
Hi, this is my first time contributing to open source code.
Is using a limiter necessary for either of the 2 functions?
If the revert command throws an error, is it necessary to deal with any chunks that would have already finished running?