Fixed #83983 added highlight collapsed#84955
Merged
aeschli merged 4 commits intomicrosoft:masterfrom Dec 19, 2019
Merged
Conversation
|
|
aeschli
requested changes
Nov 18, 2019
| }; | ||
|
|
||
| registerThemingParticipant((theme, collector) => { | ||
| const highlightCollapsedBackground = theme.getColor(editorSelectionBackground); |
Contributor
There was a problem hiding this comment.
Don't use editorSelectionBackground but define a new color.
That way users can enabled / disable / configure.
Note sure is we also need a user setting. I'd start without one, for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #83983 . With the help of @aeschli , i added a class to the collapsed visual decoration. This is then referenced in
registerThemingParticipantto match the selected color depending on the theme. IndecorationRangei set thestartColumnto 0 to ensure the highlight starts from character 0.