Make local and remote ports configurable#84958
Conversation
|
What is the scenario to support here? |
|
When vscode-web was tested on vscode-online, there was a difference between the local port number and the remote address port to check from the browser during execution. |
|
Could this be documented somehow in the args? |
|
Something like showing help output when running " |
|
|
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
Thanks for doing this, some feedback provided.
scripts/code-web.js
Outdated
| server.listen(PORT, () => { | ||
| console.log(`Web UI available at ${SCHEME}://${AUTHORITY}`); | ||
| server.listen(LOCAL_PORT, () => { | ||
| console.log(`Operating location at http://0.0.0.0:${LOCAL_PORT}`); |
There was a problem hiding this comment.
I would only print this if the local port is different from the remote? Otherwise a bit confusing
scripts/code-web.js
Outdated
| if(args.help){ | ||
| console.log( | ||
| 'yarn web [options]\n' + | ||
| ' --no-launch Launch browser\n' + |
There was a problem hiding this comment.
I think the text is wrong, if specified this does not launch the browser, right?
scripts/code-web.js
Outdated
| console.log( | ||
| 'yarn web [options]\n' + | ||
| ' --no-launch Launch browser\n' + | ||
| ' --scheme Potocol\n' + |
bpasero
added
web
Changed to show additional message only when local port is changed.
|
Thanks! |
3 participants
Modification to enable handling in cases where local port and remote port are different
#RemotePort=30000 LocalPort=8080
yarn web --port=30000 --local_port=8080