Add filter to git hook (dev qol)#85159
Merged
joaomoreno merged 3 commits intomicrosoft:masterfrom Nov 29, 2019
Merged
Conversation
Member
|
Actually, since one can also invoke |
Contributor
Author
|
I was also thinking that, but I wasn't sure if there was a scenario where we would want to just hygiene exactly what the caller passed (i.e it was intentional to pass in a file not listed by the |
Contributor
Author
|
@joaomoreno I've updated it to filter everything passed into the hygiene task, let me know what you think. |
Member
|
Excellent, thanks! 🎆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the git hook takes every change you have and starts the filter from there and bypasses the "all" filter.
This changes it so the files from the git hook are filtered through "all" first.
I considered adding the filter at https://github.com/microsoft/vscode/blob/master/build/gulpfile.hygiene.js#L332 instead, but this seems like a more targeted fix.