Add appRoot to windows protocol handler for dev#85289
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Nov 28, 2019
jzyrobert:85046_windows_protocol_handler
Merged
Add appRoot to windows protocol handler for dev#85289joaomoreno merged 1 commit intomicrosoft:masterfrom jzyrobert:85046_windows_protocol_handler
joaomoreno merged 1 commit intomicrosoft:masterfrom
jzyrobert:85046_windows_protocol_handler
Conversation
Contributor
Author
|
However, this seems to fail when your path to the vscode folder contains spaces. |
Member
|
@jzyrobert I see you already added quotes around the path. That doesn't address the issue? |
joaomoreno
changed the title
Contributor
Author
|
@joaomoreno I pushed the quotes after my previous comment (it works), is that fine? |
Member
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #85046
If
isBuiltis false,environmentService.appRootwill be added to the arguments such that electron will be able to find the app.