Add parent path to git clone command#85459
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Nov 28, 2019
Merged
Conversation
|
|
Member
|
Thanks! 🎆 |
connor4312
reviewed
Dec 3, 2019
| if (!parentPath) { | ||
| const config = workspace.getConfiguration('git'); | ||
| let defaultCloneDirectory = config.get<string>('defaultCloneDirectory') || os.homedir(); | ||
| defaultCloneDirectory = defaultCloneDirectory.replace(/^~/, os.homedir()); |
Member
There was a problem hiding this comment.
We may want to do this for provided parent paths as well; currently running a command to clone into ~/Github displays an error @joaomoreno
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #85458 by adding another argument for the parent directory to the
git.clonecommand (see #85458 for more details about the use-case that this pull-request is trying to address)