fix #85938: prevent duplicate selections#86286
Merged
isidorn merged 1 commit intomicrosoft:masterfrom Dec 4, 2019
jzyrobert:85938
Merged
fix #85938: prevent duplicate selections#86286isidorn merged 1 commit intomicrosoft:masterfrom jzyrobert:85938
isidorn merged 1 commit intomicrosoft:masterfrom
jzyrobert:85938
Conversation
Collaborator
|
Looks great! Can you just use an array and indexOf instead of a |
isidorn
requested changes
Dec 4, 2019
Collaborator
isidorn
left a comment
isidorn
left a comment
There was a problem hiding this comment.
As commented in the issue, do not use set but keep working with arrays.
Contributor
Author
|
@isidorn done |
Collaborator
|
Looks great. Just remove the usage of |
Collaborator
|
Tested it out and it is great work. Thanks a lot, I will remove the unused import. |
Contributor
Author
|
@isidorn Thanks, I should have spotted the unused import |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #85938 (and #85880 ?)
@isidorn
When creating a new empty folder, upon focusing on it, duplicate selections can occur where
selectionalready contains the object, butoldSelectionhas the id and will push it again.Will this being a set cause any issues if the objects are not in the same order as before?