got rid of duplicate "Clear Search" and "No Settings Found"#86494
Merged
roblourens merged 1 commit intomicrosoft:masterfrom Dec 7, 2019
Merged
got rid of duplicate "Clear Search" and "No Settings Found"#86494roblourens merged 1 commit intomicrosoft:masterfrom
roblourens merged 1 commit intomicrosoft:masterfrom
Conversation
Member
|
I would rather leave the "no settings found" message. I think it looks better to have something there, matches the search viewlet, and the "clear filters" link looks odd on its own. |
smilegodly
force-pushed
the
getRidOfDupes
branch
from
807c8e2 to
c639bec
Compare
Contributor
Author
|
I have put back "no settings found" message as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got rid of duplicate "Clear Search" as well as a duplicate "No Settings Found"
This PR fixes #86490