Conversation
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
This is ok but please add a comment to the matching line in the css file, mentioning that the height is also used in JS. And please extract the value 24 to a constant so it is just referenced in one place. I want to make it easier to make sure that these stay in sync.
|
|
|
ugh , I don't understand what is the problem with the "CI / linux (pull_request) " |
| export const FolderFocusKey = new RawContextKey<boolean>('folderMatchFocus', false); | ||
| export const MatchFocusKey = new RawContextKey<boolean>('matchFocus', false); | ||
|
|
||
| export const OneLineHeight = 24; |
There was a problem hiding this comment.
You can leave this in searchWidget.ts, it doesn't really apply to all of "search"
There was a problem hiding this comment.
alright thanks
| max-height: 134px; | ||
| } | ||
|
|
||
| /* Warning the height is also use in searchWidget.ts as a constant*/ |
There was a problem hiding this comment.
two minor suggestions:
- is also used
- replace 'Warning the height' with 'NOTE: height'
There was a problem hiding this comment.
yes, good idea and thanks for the spelling error
4 participants
This PR fixes #83644 , upWard and downWard