Bump node-native-keymap to 2.1.1 for easier arm64 cross-compilation#86659
Merged
alexdima merged 12 commits intomicrosoft:masterfrom Jan 14, 2020
dimkr:pkg-config
Merged
Bump node-native-keymap to 2.1.1 for easier arm64 cross-compilation#86659alexdima merged 12 commits intomicrosoft:masterfrom dimkr:pkg-config
alexdima merged 12 commits intomicrosoft:masterfrom
dimkr:pkg-config
Conversation
|
|
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a step towards fixing #6442. The black screen issue mentioned in VSCodium/vscodium#6 is the result of node-native-keymap building for x86_64, even when building VS Code for arm64.
microsoft/node-native-keymap#16 should make it possible to cross-compile for arm64 without the ugliness of https://github.com/VSCodium/vscodium/pull/302/files#diff-1cff9c2244994983620720603cbc6aa4R24.