Debounce on type history entries for "files to include/exclude" fields #86785
Merged
JacksonKearl merged 2 commits intomicrosoft:masterfrom Dec 12, 2019
Merged
Conversation
Contributor
|
Thanks! The alternative implementation makes sense, but I think we can wait to see if unexpected behavior actually arises. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #86288
While commit 520c999 fixed problem with main Search field types in "files to include/exclude" fields still produced a ton of new history entries. This PR make history entries for these fields created on type delayed in the same way as Search field to prevent pollution.
Alternative implementation can be used if there is need to handle immediate history submit in case when
triggeredOnType === false, but it looks a bit overkill if only one field can be edited at the time and it will save own history entry on Enter. Other should be already saved (even by timeout) in general case (I doubt that users will Tab to next field and continue typing so "save" will be delayed for 2 fields at the same time).