bump electron to 6.1.6, fixes missing window titles in accessibility apps#86837
Merged
deepak1556 merged 7 commits intomicrosoft:masterfrom Dec 14, 2019
Merged
bump electron to 6.1.6, fixes missing window titles in accessibility apps#86837deepak1556 merged 7 commits intomicrosoft:masterfrom
deepak1556 merged 7 commits intomicrosoft:masterfrom
Conversation
…n accessibility apps
|
|
deepak1556
reviewed
Dec 12, 2019
| "name": "electron", | ||
| "repositoryUrl": "https://github.com/electron/electron", | ||
| "commitHash": "6f62f91822a80192cb711c604f1a8f1a176f328d" | ||
| "commitHash": "19c705ab80cd6fdccca3d65803ec2c4addb9540a" |
Collaborator
There was a problem hiding this comment.
Sorry for the review on wrong line, the review ui is bad at commenting for unchanged line.
Need to bump the version a few lines below "version": "6.1.6"
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed in new commit
deepak1556
approved these changes
Dec 13, 2019
Collaborator
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
Will merge once builds are available
bpasero
approved these changes
Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #84195