Fix mirror cursor selection#86986
Merged
octref merged 3 commits intomicrosoft:masterfrom Dec 17, 2019
mrahhal:mirror-cursor-selection-fix
Merged
Fix mirror cursor selection#86986octref merged 3 commits intomicrosoft:masterfrom mrahhal:mirror-cursor-selection-fix
octref merged 3 commits intomicrosoft:masterfrom
mrahhal:mirror-cursor-selection-fix
Conversation
Contributor
|
Thanks. I added some comment and improved the logic. When it's selection (4 points), we should exit this mode when either both anchors or both actives are located in different locations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #86978
Before:
After: