Skip to content

Fix mirror cursor selection#86986

Merged
octref merged 3 commits intomicrosoft:masterfrom
mrahhal:mirror-cursor-selection-fix
Dec 17, 2019
Merged

Fix mirror cursor selection#86986
octref merged 3 commits intomicrosoft:masterfrom
mrahhal:mirror-cursor-selection-fix

Conversation

@mrahhal
Copy link
Contributor

@mrahhal mrahhal commented Dec 14, 2019

This PR fixes #86978

Before:

PP2udhl7tV

After:

egeIm9byNZ


@msftclas
Copy link

msftclas commented Dec 14, 2019

CLA assistant check
All CLA requirements met.

@octref
Copy link
Contributor

octref commented Dec 17, 2019

Thanks. I added some comment and improved the logic. When it's selection (4 points), we should exit this mode when either both anchors or both actives are located in different locations.

@octref octref added this to the December/January 2020 milestone Dec 17, 2019
@octref octref merged commit ac6f37e into microsoft:master Dec 17, 2019
@mrahhal mrahhal deleted the mirror-cursor-selection-fix branch December 18, 2019 05:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mirror cursor breaks HTML tags

3 participants