Skip to content

Fixes incorrect focused element when creating new file/folder and renaming in file explorer#87052

Merged
isidorn merged 1 commit intomicrosoft:masterfrom
jeanp413:fix-87044
Dec 17, 2019
Merged

Fixes incorrect focused element when creating new file/folder and renaming in file explorer#87052
isidorn merged 1 commit intomicrosoft:masterfrom
jeanp413:fix-87044

Conversation

@jeanp413
Copy link
Contributor

This PR fixes #87044

The tree could rerender an element and not fire the onFocusChanged event making this.compressedNavigationController invalid.

@isidorn isidorn self-assigned this Dec 16, 2019
@isidorn
Copy link
Collaborator

isidorn commented Dec 17, 2019

I have verified this fixes the issue.
Also this is a good change, since we keep less state in the explorerView.
Thanks a lot for this great pr!

@isidorn isidorn merged commit 860b51d into microsoft:master Dec 17, 2019
@isidorn isidorn added this to the December/January 2020 milestone Dec 17, 2019
@jeanp413 jeanp413 deleted the fix-87044 branch December 17, 2019 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect focused element when creating new file/folder and renaming in file explorer

2 participants