Skip to content

Refactor SortOrder & SortOrderConfiguration into one enum#87114

Merged
isidorn merged 1 commit intomicrosoft:masterfrom
jzyrobert:refactor-sortorder
Dec 18, 2019
Merged

Refactor SortOrder & SortOrderConfiguration into one enum#87114
isidorn merged 1 commit intomicrosoft:masterfrom
jzyrobert:refactor-sortorder

Conversation

@jzyrobert
Copy link
Contributor

  • Not an issue fix, but as part of a previous PR I noticed that a separate object SortOrderConfiguration and type SortOrder are used to emulate an enum.
  • Also replaced 2 occurrences of direct string comparison with the enum equivalent.

@bpasero bpasero assigned isidorn and unassigned bpasero Dec 17, 2019
@isidorn
Copy link
Collaborator

isidorn commented Dec 17, 2019

@jzyrobert thanks for this. Did you verify that this does not break anything and that the explorer.sortOrder still works as expected?
Can you please resolve conflicts with master and then we can look into merging this? Thanks

@jzyrobert
Copy link
Contributor Author

@isidorn Works as before:
2019-12-17_20-52-09

I have rebased and resolved the conflict.

@isidorn
Copy link
Collaborator

isidorn commented Dec 18, 2019

Thanks a lot for this. Merging in.

@isidorn isidorn merged commit d5dc53e into microsoft:master Dec 18, 2019
@isidorn isidorn added this to the December/January 2020 milestone Dec 18, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants