Add CompletionItem conversion for additionalTextEdits#87648
Merged
jrieken merged 1 commit intomicrosoft:masterfrom Dec 31, 2019
jzyrobert:87346-additionalTextEdits
Merged
Add CompletionItem conversion for additionalTextEdits#87648jrieken merged 1 commit intomicrosoft:masterfrom jzyrobert:87346-additionalTextEdits
jrieken merged 1 commit intomicrosoft:masterfrom
jzyrobert:87346-additionalTextEdits
Conversation
jrieken
requested changes
Dec 30, 2019
Member
There was a problem hiding this comment.
For commands, use
(which you somehow need to get here)
jrieken
requested changes
Dec 31, 2019
Member
There was a problem hiding this comment.
Why the if-defence? Shouldn't the type always be correct?
Contributor
Author
There was a problem hiding this comment.
The edits.text of type ISingleEditOperation are possibly null, while modes.TextEdit requires a non-null string.
Is casting it to the type is sufficient?
Member
There was a problem hiding this comment.
Yeah - cast it. It's TextEdit-objects that have sourced them, so they should be well defined.
Contributor
Author
There was a problem hiding this comment.
Renove the range check as well? Or keep it.
Contributor
Author
|
☢ @jrieken ☢ |
jrieken
approved these changes
Dec 31, 2019
Member
|
looking good now. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #87346
Running the sample repo,
Before:
After:
