Skip to content

Replace 'declare var' with 'declare const'#87709

Merged
jrieken merged 1 commit intomicrosoft:masterfrom
Ikuyadeu:vat2const
Dec 31, 2019
Merged

Replace 'declare var' with 'declare const'#87709
jrieken merged 1 commit intomicrosoft:masterfrom
Ikuyadeu:vat2const

Conversation

@Ikuyadeu
Copy link
Contributor

@Ikuyadeu Ikuyadeu commented Dec 26, 2019

This PR is related #87644

Hello, I made this PR based on a73867d that is created by @jrieken.
And I found automatically some remained fixable contents.

p.s. Space removings are automatically done by tslint.

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jrieken jrieken added this to the January 2020 milestone Dec 31, 2019
@jrieken jrieken merged commit 75115f1 into microsoft:master Dec 31, 2019
@Ikuyadeu
Copy link
Contributor Author

Ikuyadeu commented Jan 1, 2020

@jrieken Thank you!
BTW, these changes are made by DevReplay plugin that found recent similar changes microsoft/vscode activity, such as here
If you have an interest in your rules, please give me a feedback.

@Ikuyadeu Ikuyadeu deleted the vat2const branch January 1, 2020 05:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants