Skip to content

Roblox XML file syntax highlight support#87755

Merged
alexr00 merged 3 commits intomicrosoft:masterfrom
violetshine:master
Jan 7, 2020
Merged

Roblox XML file syntax highlight support#87755
alexr00 merged 3 commits intomicrosoft:masterfrom
violetshine:master

Conversation

@violetshine
Copy link

@violetshine violetshine commented Dec 27, 2019

I work with Rojo every day. However it is really annoying when VS Code doesn't syntax highlight Roblox place or model files and I have to manually select XML as the language. Roblox files are in XML format so I just added those extensions to XML syntax highlighting extension json

EDIT: This is my first PR ever so if I am doing something wrong, not following contributing guide 100%, something is missing or something like that, please let me know and I will fix that

@kieferrm kieferrm requested a review from alexr00 December 27, 2019 18:52
@alexr00 alexr00 added this to the January 2020 milestone Jan 6, 2020
@alexr00
Copy link
Member

alexr00 commented Jan 6, 2020

Roblox seems pretty specific. @aeschli how specific is too specific for adding file extensions?

@cat-kitten one solution for you would be to add a file association in your settings:

	"files.associations": {
		"*.rbxlx": "xml"
	}

@aeschli
Copy link
Contributor

aeschli commented Jan 7, 2020

@alexr00 As the extension is so specific I think we can add it to our defaults, for a good initial user experience.

@alexr00 alexr00 merged commit db0c41c into microsoft:master Jan 7, 2020
@tisaconundrum2
Copy link

I'm over here reviewing the change log and I see robolox. I couldn't help but come over here to find out the reason behind this. Congrats @cat-kitten on your first merged PR.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants