Roblox XML file syntax highlight support#87755
Merged
alexr00 merged 3 commits intomicrosoft:masterfrom Jan 7, 2020
violetshine:master
Merged
Roblox XML file syntax highlight support#87755alexr00 merged 3 commits intomicrosoft:masterfrom violetshine:master
alexr00 merged 3 commits intomicrosoft:masterfrom
violetshine:master
Conversation
Member
|
Roblox seems pretty specific. @aeschli how specific is too specific for adding file extensions? @cat-kitten one solution for you would be to add a file association in your settings: |
Contributor
|
@alexr00 As the extension is so specific I think we can add it to our defaults, for a good initial user experience. |
alexr00
approved these changes
Jan 7, 2020
|
I'm over here reviewing the change log and I see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I work with Rojo every day. However it is really annoying when VS Code doesn't syntax highlight Roblox place or model files and I have to manually select XML as the language. Roblox files are in XML format so I just added those extensions to XML syntax highlighting extension json
EDIT: This is my first PR ever so if I am doing something wrong, not following contributing guide 100%, something is missing or something like that, please let me know and I will fix that