CallStackView attempts to move the active frame to the top

[mnovakovic]

This PR fixes #88073

This is an attempt to fix the above issue.

If the element we're selecting is a StackFrame and it's not on the screen, I attempt to put the associated Thread at the very top of the list view. I don't force it as if the element is already on the screen, it'll scroll if up forcefully, which is not a good UX imo.

I'd appreciate any comments, there is a lot going in the code to render a stack trace, this seemed like an easy and non-invasive way to make this a little more intuitive.

[isidorn]

Thanks for submiting this PR.
I agree we could improve this behavior and I think your approach makes sense.

However it might be a bit overly complex to me and I think we can simplify this.
How about that in the reveal you just pass 0.5, that should just reveal the active frame in the middle making it easier to see the rest of the frames. Can you try that out and if it looks good update the PR? Thanks!

[mnovakovic]

@isidorn - Did the change you recommended and it's not a bad idea at all. I still only move the element to the middle it is outside of the visible area as otherwise it's forcefully moved there every time you step over or select a frame, which seems a little intrusive.

[mnovakovic]

ping, just making sure you haven't forgotten about this :) @isidorn @egamma

[isidorn]

Looks good, thanks for this PR. Merging in ☀️