Skip to content

#88125 Reverse action order in goToErrorWidget#88167

Merged
jrieken merged 1 commit intomicrosoft:masterfrom
jzyrobert:88125-reverse-action-order
Jan 7, 2020
Merged

#88125 Reverse action order in goToErrorWidget#88167
jrieken merged 1 commit intomicrosoft:masterfrom
jzyrobert:88125-reverse-action-order

Conversation

@jzyrobert
Copy link
Contributor

This PR fixes #88125

I removed the use of HORIZONTAL_REVERSE and added the buttons in reverse order instead.
I believe you could set the tabIndex of the actions to be 2 and 1, but according to this it is better to order the elements correctly.

Demo:
MRya8gbIOn

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jrieken jrieken added this to the January 2020 milestone Jan 7, 2020
@jrieken
Copy link
Member

jrieken commented Jan 7, 2020

Thanks!

@jrieken jrieken merged commit 806f1e5 into microsoft:master Jan 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected tab order for buttons in marker navigation widget

2 participants