Skip to content

Add ability to change screencast keyboard font size#88308

Merged
lszomoru merged 8 commits intomicrosoft:masterfrom
AlexStrNik:screencast-font-size
May 12, 2020
Merged

Add ability to change screencast keyboard font size#88308
lszomoru merged 8 commits intomicrosoft:masterfrom
AlexStrNik:screencast-font-size

Conversation

@AlexStrNik
Copy link
Contributor

@AlexStrNik AlexStrNik commented Jan 8, 2020 •
edited
Loading

Add the ability to change screencast keyboard font size. This PR adds screencastMode.fontSize setting.
Fixes #88097

@connor4312 connor4312 requested review from bpasero and joaomoreno and removed request for bpasero and joaomoreno January 8, 2020 23:29
@bpasero bpasero assigned joaomoreno and unassigned bpasero Jan 9, 2020
@AlexStrNik
Copy link
Contributor Author

AlexStrNik commented Jan 9, 2020

Some examples:

image
image
image

@AlexStrNik
Copy link
Contributor Author

AlexStrNik commented Jan 9, 2020

After some thought, I decided to rework the keyboard's height calculation method. Now it looks much better.

image
Maximum size
image
Minimum size
image
And at last default size

@joaomoreno joaomoreno added this to the Backlog milestone Jan 14, 2020
@AlexStrNik
Copy link
Contributor Author

AlexStrNik commented Jan 15, 2020 •
edited
Loading

@joaomoreno why not release this feature in January 2020? As far as I know, Endgame hasn't started yet. And I hope this feature will be helpful for someone

@AlexStrNik
Copy link
Contributor Author

AlexStrNik commented Feb 7, 2020

@joaomoreno any updates about this PR?

@JUD210
Copy link

JUD210 commented Mar 16, 2020

I can't believe why it isn't merged yet!
WHY?

@AlexStrNik AlexStrNik mentioned this pull request May 12, 2020
Merged
@lszomoru lszomoru self-requested a review May 12, 2020 09:04
@lszomoru lszomoru self-assigned this May 12, 2020
@lszomoru lszomoru modified the milestones: Backlog, May 2020 May 12, 2020
joaomoreno
joaomoreno requested changes May 12, 2020
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS still references a fontSize: 56px for the .screencast-keyboard element.

lszomoru
lszomoru reviewed May 12, 2020
View reviewed changes
lszomoru
lszomoru reviewed May 12, 2020
View reviewed changes
lszomoru
lszomoru reviewed May 12, 2020
View reviewed changes
lszomoru
lszomoru reviewed May 12, 2020
View reviewed changes
@lszomoru
Copy link
Member

lszomoru commented May 12, 2020

@AlexStrNik, it seems that you would have to move the css changes into actions.css since screencast.css was renamed.

AlexStrNik and others added 3 commits May 12, 2020 16:40
@AlexStrNik
Remove unused css rule
5a9b405
@AlexStrNik
Add value check
dff8bf6
@AlexStrNik @lszomoru
Update src/vs/workbench/browser/actions/media/screencast.css
9441d6a 
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
@AlexStrNik
Copy link
Contributor Author

AlexStrNik commented May 12, 2020

@AlexStrNik, it seems that you would have to move the css changes into actions.css since screencast.css was renamed.

Done!

@lszomoru lszomoru merged commit 8456789 into microsoft:master May 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joaomoreno joaomoreno joaomoreno requested changes

@lszomoru lszomoru lszomoru approved these changes

Assignees

@joaomoreno joaomoreno

@lszomoru lszomoru

Labels

screencast-mode

Projects

None yet

Milestone

May 2020

Development

Successfully merging this pull request may close these issues.

[Screencast Mode] Allow users to customize font sizes for displaying keyboard shortcuts

5 participants

@AlexStrNik @JUD210 @lszomoru @joaomoreno @bpasero