Add support for multiple rulers with different colors#88453
Add support for multiple rulers with different colors#88453alexdima merged 7 commits intomicrosoft:masterfrom
Conversation
This change set: adds an interface for Ruler Color Options, adds a union type of that interface and number, adjust the rulers type hint to use said union type, adds a mechanism to apply boxshadow to fastDomNode, and updates the way rulers are rendered to support individual colors. I've also ensured that descriptions are provided for settings.json. So now, all nodes will provide explanations.
|
@mallardduck Thanks for doing the PR. I’m excited to use this feature! |
|
Looks like the merge failed due to a problem with the actual test, but not sure. Line 11 just says Run .\scripts\test-integration.bat --tfs "Integration Tests"
Active code page: 65001
"Running integration tests out of sources."
undefined
Search-integration
√ Text: GameOfLife (51ms)
√ Text: GameOfLife (RegExp) (57ms)
√ Text: GameOfLife (unicode escape sequences) |
|
@methodbox I think that's not the cause of the failure. If you check, the same test for different commits on this PR that message was being thrown in all of them without failure. |
|
@methodbox, yeah looks fine now. Just need someone from Microsoft to review, give feedback and/or accept it. |
|
@connor4312 @alexdima - Hey there, I know that I read that multiple ruler colors was in a backlog for a later release point. However I'm wondering if we can get this merged in sooner than later, since I have provided a working implementation? |
|
Thank you! |
|
Any idea when this will make it into distributed builds? |
|
@methodbox This will make it to insiders in the next couple days (insiders is now frozen until stable is shipped), and will come to stable with the February stable release ~4weeks from nwo |
This change set:
I've also ensured that descriptions are provided for settings.json. So now, all nodes will provide explanations.
There may be other ways to implement adjusting the boxShadow - certainly open for input if adding the
setBoxShadowisn't as preferred.This PR fixes #54312 by allowing ruler colors to be defined in
settings.json.