Merged
Conversation
|
|
alexdima
requested changes
Jan 19, 2020
Member
alexdima
left a comment
alexdima
left a comment
There was a problem hiding this comment.
The editor should avoid creating globals or changing the prototype of globals. We need to figure out how to remove these hacks before merging.
…standalone editor calls are qualified
Member
|
Thank you! ❤️ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the usage of the
monaco-editor-corein shadowDOM (see this issue to get more details - microsoft/monaco-editor#308).This request is based on some changes proposed in https://github.com/paulvarache/monaco-editor-element.
This PR assumes that, when the monaco-editor-core runs in a shadow DOM, the shadow root should be assigned to
window.monacoShadowRoot. It is a workaround to make it visible in all the classes/helpers that deal with the DOM (e.g. dom.ts). I would like to know how can we attach it to a Monaco instance instead of having it global.Lastly, since some browsers do not implement all the functions needed for the ShadowDOM, I had to add some polyfills. They were added to
editorDom.ts(I am not sure if it's the most suitable place)