Fix #88294 Add commitData in commit interface#89005
Merged
joaomoreno merged 6 commits intomicrosoft:masterfrom Feb 18, 2020
Merged
Fix #88294 Add commitData in commit interface#89005joaomoreno merged 6 commits intomicrosoft:masterfrom
joaomoreno merged 6 commits intomicrosoft:masterfrom
Conversation
|
|
zjysdhr
changed the title
Contributor
Author
|
by #89262, we only need to add commitData. |
Member
|
Thanks! 👍 |
Member
|
@joaomoreno I had to revert this via aa70f38 because it was causing a test to fail, and it appeared to be a real failure, not just a test fluke. |
alexdima
referenced
this pull request
Feb 18, 2020
Member
|
Thanks for the heads up @alexdima |
Member
|
I've fixed it: the tests needed adoption. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #88294