Friendly pickstring options#89180
Merged
alexr00 merged 7 commits intomicrosoft:masterfrom Jan 24, 2020
LarssonOliver:friendly-pickstring
Merged
Friendly pickstring options#89180alexr00 merged 7 commits intomicrosoft:masterfrom LarssonOliver:friendly-pickstring
alexr00 merged 7 commits intomicrosoft:masterfrom
LarssonOliver:friendly-pickstring
Conversation
alexr00
reviewed
Jan 24, 2020
src/vs/workbench/services/configurationResolver/browser/configurationResolverService.ts
Outdated
Show resolved
Hide resolved
alexr00
requested changes
Jan 24, 2020
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Looks good, just a few small changes!
src/vs/workbench/services/configurationResolver/common/configurationResolverSchema.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #84983
Implemented a way to allow for seperate display names when specifying options for a pickString.
Would be used like this:
{ "type": "pickString", "id": "options", "description": "description", "options": [ "option1", { "name": "Option number 2", "value": "option2" }, { "value": "option3" } ], "default": "option2" }The user can specify an option as either a string, or an object with the name and value of the option.
This would show up in the selection list like this: