Developed setting which controls whether the definition link opens element in the peek widget.#89884
Developed setting which controls whether the definition link opens element in the peek widget.#89884jrieken merged 2 commits intomicrosoft:masterfrom GustavoASC:master
Conversation
… the mouse click opens element definition in the peek widget.
|
Oh, I'd like to point this out. When this setting is true I can open 'peek' inside 'peek' with ctrl+click.
|
That's unwanted behaviour |
Thanks for your feedback! I just noticed that on issue #6857 you mentioned:
Maybe if I solve issue #6857, the behaviour of the current PR will be solved as well. Anyway, I'll take a look on that! 👍 |
| description: nls.localize('peekWidgetDefaultFocus', "Controls whether to focus the inline editor or the tree in the peek widget.") | ||
| } | ||
| )), | ||
| mouseOpensDefinitionInPeek: register(new EditorBooleanOption( |
There was a problem hiding this comment.
Overall looking quite good. Not yet sold on the name, maybe have definitionLink or symbolLink with value set peek | goto ("goto" isn't the best option because it might peek) or for a boolean value something like definitionLinkOpensInPeek?
There was a problem hiding this comment.
Yeah, I created a config yesterday with values like peek | goto but since it's not always goto (it might peek) I decided to create a boolean.
I liked your idea to rename it to definitionLinkOpensInPeek.
GustavoASC
changed the title
|
Thanks! |
|
@jrieken Uhm, I noticed that 'peek inside peek' already happens today even in 1.41. If we use "Peek definition" menu and after that mouse+click an element which has multiple definition, a peek widget is open recursively.
Should I open an issue to solve this? According to @stevencl comment on #6857 it's not that simple to have 'breadcrumbs' like VS. |
|
Can you try with insiders? There was something I have recently fixed, tho unsure if it also covers that. Otherwise, yeah file an issue please |
|
Tested on Insiders and works fine 👍 |
2 participants
This PR fixes #62571.
Now there is a setting to control whether the mouse click opens element definition in the peek widget, which is equivalent to Visual Studio configuration.
Default is false to maintain the same behavior as before (tipically opening the definition in a new window).