Use MutationObserver for Monaco Editor AutomaticLayout#90111
Merged
alexdima merged 2 commits intomicrosoft:masterfrom Feb 6, 2020
nrayburn-tech:master
Merged
Use MutationObserver for Monaco Editor AutomaticLayout#90111alexdima merged 2 commits intomicrosoft:masterfrom nrayburn-tech:master
alexdima merged 2 commits intomicrosoft:masterfrom
nrayburn-tech:master
Conversation
Contributor
Author
|
ResizeObserver could be used instead for browsers that support it, but I wasn't really sure if that should be in the same request or not. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When changing the size of the editor container that uses the AutomaticLayout option, the editor content updates based on dom mutations instead of waiting on a time interval.
This should work the same as the previously used time interval, but without the performance issues.
This PR fixes #1266