Clarify language when creating new git branch#90160
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Feb 7, 2020
iannotian:eyeino/clarify-new-branch-prompt
Merged
Clarify language when creating new git branch#90160joaomoreno merged 1 commit intomicrosoft:masterfrom iannotian:eyeino/clarify-new-branch-prompt
joaomoreno merged 1 commit intomicrosoft:masterfrom
iannotian:eyeino/clarify-new-branch-prompt
Conversation
When using the git extension, the intent is clear when clicking on "+ Create new branch..." and immediately being prompted "Please provide a branch name". But, when clicking on "+ Create a new branch from..." the intent is ambiguous, since the statement "Please provide a branch name" could refer to the branch from which you wish to base the new branch on or the name of the new branch, the latter being what actually happens. By specifying "Please provide a *new* branch name...", the intent is clear: the prompt is asking for the name you wish to call the new branch.
gjsjohnmurray
suggested changes
Feb 7, 2020
Contributor
gjsjohnmurray
left a comment
gjsjohnmurray
left a comment
There was a problem hiding this comment.
Maybe make placeholder be "New branch name"
Maybe expand prompt to read "Please provide a name for the new branch"
Member
|
Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the git extension, the intent is clear when clicking on "+ Create new branch..." and immediately being prompted "Please provide a branch name". But, when clicking on "+ Create a new branch from..." the intent is ambiguous, since the statement "Please provide a branch name" could refer to the branch from which you wish to base the new branch on or the name of the new branch, the latter being what actually happens.
By specifying "Please provide a new branch name...", the intent is clear: the prompt is asking for the name you wish to call the new branch.
This PR fixes #90158