Add new action to close side bar#90404
Merged
sbatten merged 1 commit intomicrosoft:masterfrom Feb 11, 2020
sirmspencer:master
Merged
Add new action to close side bar#90404sbatten merged 1 commit intomicrosoft:masterfrom sirmspencer:master
sbatten merged 1 commit intomicrosoft:masterfrom
sirmspencer:master
Conversation
|
|
Member
|
@sirmspencer thanks for the PR, we already have a command for toggling the visibility of the sidebar so this command is redundant. yes, the same is true for the panel, but I don't think we should mimic that behavior. |
Contributor
Author
|
There is no way to tell if the side bar is open. When Im working inside my extension, I need to be sure that I am only closing the side bar, not toggling. |
Member
|
@sirmspencer fair. seeing now we have had a long standing request to access context keys within extension code, but it has not happened. will merge this |
sbatten
approved these changes
Feb 11, 2020
Contributor
Author
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new action to close the side bar called
workbench.action.closeSidebar. This matches the existingworkbench.action.closePanel.