Skip to content

Added a password attribute to input variable of type "promptString".#90482

Merged
alexr00 merged 2 commits intomicrosoft:masterfrom
jlittorin:promptStringPassword
Feb 20, 2020
Merged

Added a password attribute to input variable of type "promptString".#90482
alexr00 merged 2 commits intomicrosoft:masterfrom
jlittorin:promptStringPassword

Conversation

@jlittorin
Copy link

Setting the password attribute to true will cause the UI to not show the type value.

"inputs": [
  {
    "id": "authPassword",
    "type": "promptString",
    "description": "Password for authentication",
    "password": true
  }
]

This PR fixes #90481

…Setting this attribute to true will cause the UI to not show the type value.
@msftclas
Copy link

msftclas commented Feb 11, 2020

CLA assistant check
All CLA requirements met.

@jlittorin jlittorin requested a review from alexr00 February 11, 2020 20:53
@jlittorin jlittorin changed the title Added a password attribute to variable input of type "promptString". Added a password attribute to input variable of type "promptString". Feb 11, 2020
@alexr00 alexr00 added this to the February 2020 milestone Feb 17, 2020
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@alexr00 alexr00 merged commit d3cc58d into microsoft:master Feb 20, 2020
@jlittorin
Copy link
Author

Looks good, thanks for the PR!

Thanks, @alexr00! Since this changes the API slightly I should also update the corresponding documentation, I guess. Can I just go do that in the wiki-repo? How is that synced with releases of the app?

@alexr00
Copy link
Member

alexr00 commented Feb 21, 2020

If you would update the docs that would be awesome. Only this file should need to be changed: https://github.com/microsoft/vscode-docs/blob/538606e34aa67fd266cfcce79a3830c92b093e32/docs/editor/variables-reference.md#L103-L104
You can use the vnext branch as your base for the PR. We merge around the same time as releasing VS Code. If you can @ mention me in the PR description then I'll see the it faster too.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add password attribute to input variable type "promptString"

3 participants