Added a password attribute to input variable of type "promptString".#90482
Merged
alexr00 merged 2 commits intomicrosoft:masterfrom Feb 20, 2020
Merged
Added a password attribute to input variable of type "promptString".#90482alexr00 merged 2 commits intomicrosoft:masterfrom
alexr00 merged 2 commits intomicrosoft:masterfrom
Conversation
…Setting this attribute to true will cause the UI to not show the type value.
alexr00
approved these changes
Feb 20, 2020
Member
alexr00
left a comment
There was a problem hiding this comment.
Looks good, thanks for the PR!
Author
Thanks, @alexr00! Since this changes the API slightly I should also update the corresponding documentation, I guess. Can I just go do that in the wiki-repo? How is that synced with releases of the app? |
Member
|
If you would update the docs that would be awesome. Only this file should need to be changed: https://github.com/microsoft/vscode-docs/blob/538606e34aa67fd266cfcce79a3830c92b093e32/docs/editor/variables-reference.md#L103-L104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the password attribute to true will cause the UI to not show the type value.
This PR fixes #90481