Skip to content

Add minimap slider color options#90631

Merged
alexdima merged 2 commits intomicrosoft:masterfrom
baileyherbert:minimap-slider
Feb 17, 2020
Merged

Add minimap slider color options#90631
alexdima merged 2 commits intomicrosoft:masterfrom
baileyherbert:minimap-slider

Conversation

@baileyherbert
Copy link
Contributor

@baileyherbert baileyherbert commented Feb 13, 2020 •
edited
Loading

PR #58324 added support for customizing the minimap background color.

This PR allows the slider colors to be customized as well. The default colors are the same as before.

"workbench.colorCustomizations": {
    "minimapSlider.background": "#ff000020",
    "minimapSlider.hoverBackground": "#ff000050",
    "minimapSlider.activeBackground": "#ff000080"
},

@baileyherbert baileyherbert changed the title Add slider color options Add minimap slider color options Feb 13, 2020
JorgeT10
JorgeT10 approved these changes Feb 14, 2020
View reviewed changes
Copy link

@JorgeT10 JorgeT10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexdima alexdima added the editor-minimap Code/Text minimap widget issues label Feb 17, 2020
@alexdima alexdima added this to the February 2020 milestone Feb 17, 2020
@alexdima
Copy link
Member

alexdima commented Feb 17, 2020

Thank you!

@alexdima alexdima merged commit 634068a into microsoft:master Feb 17, 2020
@baileyherbert baileyherbert deleted the minimap-slider branch February 17, 2020 22:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JorgeT10 JorgeT10 JorgeT10 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexdima alexdima

Labels

editor-minimap Code/Text minimap widget issues

Projects

None yet

Milestone

February 2020

Development

Successfully merging this pull request may close these issues.

3 participants

@baileyherbert @alexdima @JorgeT10