Conversation
added 2 commits
February 21, 2020 17:23
Avoid any potential issue with globbing or word splitting. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Exporting XDG_CACHE_HOME affects applications launched from within the context of code. Rename it to GDK_CACHE_DIR and do not export it. Also test for existence before creating to avoid shelling out to mkdir if not needed. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
|
|
Member
|
Sorry @sergiusens but I can't seem to correlate these changes with the issue? Does this address the issue at all, or you just think |
joaomoreno
added
engineering
Author
|
XDG_CACHE_HOME if set, will make firefox open using a cache on that path, hence leading to not using the firefox a user has configured. This is going to be the next issue for that issue. |
Member
|
@sergiusens Got it. Yup, I verify that the issue is still there, even with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to #87971 or #85344 but does not entirely fix it