Skip to content

Comments

Fix terminal link hovers for local links#91615

Merged
Tyriar merged 2 commits intomicrosoft:masterfrom
jmbockhorst:terminalLinkRanges
Apr 10, 2020
Merged

Fix terminal link hovers for local links#91615
Tyriar merged 2 commits intomicrosoft:masterfrom
jmbockhorst:terminalLinkRanges

Conversation

@jmbockhorst
Copy link
Contributor

Fixes #91479. Not sure why uris was ever needed to be set, it seems to work fine without it.

@Tyriar
Copy link
Member

Tyriar commented Apr 10, 2020

It correctly shows now but clicking on it does nothing and results in:

image

Checking #91477 to see if that fixes that part.

@Tyriar Tyriar merged commit 0da15c3 into microsoft:master Apr 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal "Follow Link" popup doesn't appear for local links with link numbers

2 participants