Add action to focus query editor widget#94799
Conversation
|
|
JacksonKearl
left a comment
JacksonKearl
left a comment
There was a problem hiding this comment.
Looks good, just a few minor changes.
| 'Search Editor: Search Again', category); | ||
|
|
||
| registry.registerWorkbenchAction(SyncActionDescriptor.create(FocusQueryEditorWidgetAction, FocusQueryEditorWidgetAction.ID, FocusQueryEditorWidgetAction.LABEL), | ||
| 'Search Editor: Focus Query Editor Widget', category); |
There was a problem hiding this comment.
I'd default this to be bound to Escape, then we can remove the existing line binding it to Escape in searchEditor.ts and instead use only this. That way people that want to use Escape for other things aren't conflicting.
| if (viewState && viewState.focused === 'editor') { | ||
| this.queryEditorWidget.searchInput.focus(); | ||
| } else { | ||
| this.searchResultEditor.focus(); |
There was a problem hiding this comment.
No real need to make this toggle, it can simply call this.queryEditorWidget.searchInput.focus();
kdnk
changed the title
| 'Search Editor: Search Again', category); | ||
|
|
||
| registry.registerWorkbenchAction(SyncActionDescriptor.create(FocusQueryEditorWidgetAction, FocusQueryEditorWidgetAction.ID, FocusQueryEditorWidgetAction.LABEL, | ||
| { mac: { primary: KeyCode.Escape } }, ContextKeyExpr.and(SearchEditorConstants.InSearchEditor)), |
There was a problem hiding this comment.
This can just be { primary: KeyCode.Escape }, rather than being mac specific. Some of the other bindings are macOS specific because Windows binds them to system commands, but that isn't the case here.
|
Looks good, thanks! |
3 participants
This PR fixes #94439