Prevent CodeLens CSS selector name from being invalid#95005
Merged
jrieken merged 2 commits intomicrosoft:masterfrom Apr 14, 2020
Merged
Prevent CodeLens CSS selector name from being invalid#95005jrieken merged 2 commits intomicrosoft:masterfrom
jrieken merged 2 commits intomicrosoft:masterfrom
Conversation
jrieken
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #94958
In the codelensController, there is an issue when the class name for the codeLens span element gets generated on line 70.
Adding an underscore in front of the hashed editor ID should allow any id value to accepted as a valid CSS selector (since underscores are always allowed to start CSS selectors).