change all instances of wordHighligher to wordHighlighter#95830
Merged
alexdima merged 1 commit intomicrosoft:masterfrom Apr 27, 2020
dustypomerleau:hl
Merged
change all instances of wordHighligher to wordHighlighter#95830alexdima merged 1 commit intomicrosoft:masterfrom dustypomerleau:hl
wordHighligher to wordHighlighter#95830alexdima merged 1 commit intomicrosoft:masterfrom
dustypomerleau:hl
Conversation
|
|
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to all contributors for this awesome editor.
Merging this PR is optional, as the code in
wordHighlighter.tsworks as intended (the property with the typo is private, and the typo is perfectly reproduced each time it is used in theWordHighlighterContributionclass). However, I think it future-proofs any potential code re-use down the road to correct all occurrences of the typo now.