Skip to content

Comments

Register loading icon for async tree#95885

Merged
aeschli merged 3 commits intomicrosoft:masterfrom
IllusionMH:tree-loading-icon-95878
Apr 22, 2020
Merged

Register loading icon for async tree#95885
aeschli merged 3 commits intomicrosoft:masterfrom
IllusionMH:tree-loading-icon-95878

Conversation

@IllusionMH
Copy link
Contributor

This PR fixes #95878

I haven't found easy way to reference icon class for toggling expect to create common method which will be compatible with toggleClass. Other option would be to manually put whole class name or 'codicon-' + Codicon.icon.id (which looks even worse).

Moved icons to separate file to ensure that order won't depend on imports order and made is similar to searchIcons.ts

/cc @aeschli

@aeschli
Copy link
Contributor

aeschli commented Apr 22, 2020

@IllusionMH Thanks for jumping on it, I already started working on a solution where there's only one icon set at a time (the order in css should never matter)

@aeschli aeschli self-assigned this Apr 22, 2020
@aeschli aeschli merged commit 8350ceb into microsoft:master Apr 22, 2020
@aeschli aeschli added this to the April 2020 milestone Apr 22, 2020
@IllusionMH
Copy link
Contributor Author

I was thinking about this approach but wouldn't it also remove codicon class from element?

@aeschli
Copy link
Contributor

aeschli commented Apr 22, 2020

Yes, but it's added again if needed for the twisty.

@aeschli
Copy link
Contributor

aeschli commented Apr 22, 2020

I created #95915 for a fix to avoid depending on the definition order

@aeschli
Copy link
Contributor

aeschli commented Apr 22, 2020

it also remove codicon class from element

Oh, I see, that can happen when the twisty class name is removed.

Let's see if #95915 goes through, otherwise I fix it

@IllusionMH
Copy link
Contributor Author

Oh I see, this approach should work because of later classes change in abstractTree, but not in general case.

Thanks for review and update!

@IllusionMH IllusionMH deleted the tree-loading-icon-95878 branch April 22, 2020 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loading icon is not showing for slow tree nodes

2 participants