Register loading icon for async tree#95885
Merged
aeschli merged 3 commits intomicrosoft:masterfrom Apr 22, 2020
Merged
Conversation
Contributor
|
@IllusionMH Thanks for jumping on it, I already started working on a solution where there's only one icon set at a time (the order in css should never matter) |
Contributor
Author
|
I was thinking about this approach but wouldn't it also remove |
Contributor
|
Yes, but it's added again if needed for the twisty. |
Contributor
|
I created #95915 for a fix to avoid depending on the definition order |
Contributor
Oh, I see, that can happen when the twisty class name is removed. Let's see if #95915 goes through, otherwise I fix it |
Contributor
Author
|
Oh I see, this approach should work because of later classes change in Thanks for review and update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #95878
I haven't found easy way to reference icon class for toggling expect to create common method which will be compatible with
toggleClass. Other option would be to manually put whole class name or'codicon-' + Codicon.icon.id(which looks even worse).Moved icons to separate file to ensure that order won't depend on imports order and made is similar to
searchIcons.ts/cc @aeschli