Focus next item in list after removing breakpoint#96287
Merged
isidorn merged 2 commits intomicrosoft:masterfrom May 4, 2020
Merged
Focus next item in list after removing breakpoint#96287isidorn merged 2 commits intomicrosoft:masterfrom
isidorn merged 2 commits intomicrosoft:masterfrom
Conversation
isidorn
requested changes
Apr 28, 2020
| if (this.isBodyVisible()) { | ||
| this.updateSize(); | ||
| if (this.list) { | ||
| const lastFocusIndex = this.list.getFocus()[0]; |
Collaborator
There was a problem hiding this comment.
lastFocusIndex can be undefined, since getFocus can return an empty array.
Also do not check against equality with -1.
Collaborator
|
@ChrisPapp thanks for this PR. I left some comments, once you address them we can merge this in. |
Collaborator
|
Works nicely. Thanks for this PR, merging in ☀️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #96074