Skip to content

add <path>:line <line> goto pattern #95856#96535

Merged
bpasero merged 1 commit intomicrosoft:masterfrom
iliazeus:95856-go-to-line-patterns
May 7, 2020
Merged

add <path>:line <line> goto pattern #95856#96535
bpasero merged 1 commit intomicrosoft:masterfrom
iliazeus:95856-go-to-line-patterns

Conversation

@iliazeus
Copy link
Contributor

Adds a <path>:line <line> pattern to extractRangeFromFilter(). Also, changes the regex to use named capture groups for (hopefully) better readability.

This PR fixes #95856

@bpasero bpasero added this to the May 2020 milestone Apr 29, 2020
@bpasero
Copy link
Member

bpasero commented May 2, 2020

@iliazeus can you also add tests to [1] for covering your new support

[1]

suite('extractRangeFromFilter', () => {

@bpasero
Copy link
Member

bpasero commented May 6, 2020

@iliazeus ping

@iliazeus
Copy link
Contributor Author

iliazeus commented May 7, 2020

@bpasero sorry for the delay. I've added a test covering the new case.

@bpasero bpasero merged commit 860e808 into microsoft:master May 7, 2020
@bpasero
Copy link
Member

bpasero commented May 7, 2020

Thanks!

@hughbe
Copy link

hughbe commented May 7, 2020

Awesome, thanks @iliazeus! Hopefully this will make a lot of people's lives easier - definitely mine!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go To Line should include "filename.extension:line number" format

3 participants