Clear out stale CSS style properties on webview#96665
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom May 5, 2020
Merged
Conversation
Collaborator
|
Thanks. This will be in the first VS Code 1.46 insiders and is scheduled to ship with VS Code 1.46 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #96621
Tested by loading an extension with a webview and switching themes, confirming that stale theme properties are removed, and all expected theme properties remain. Some gifs of before and after theme changes show that the blue terminal correctly switches to grey after this change:
Before:
After:
